Remove log feature #1738
Closed
Remove log feature #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdezeeuw
force-pushed
the
log-required
branch
from
ff3fe80
to
129f859
Compare
Thomasdezeeuw
force-pushed
the
log-required
branch
from
129f859
to
1005bf7
Compare
|
Why not keep it optional? |
I like to reduce the set of features we have to support going into v1. |
atouchet
reviewed
Dec 14, 2023
Thomasdezeeuw
commented
Dec 17, 2023
|
Honestly, I would prefer that we keep it optional. It decreases the list of dependencies required by Tokio. Having less features may normally reduce the maintenance burden, but in this case, adding dependencies that are likely to break Tokio's MSRV is a significant maintenance burden for me. |
|
We can keep it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.