Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to windows-sys 0.42.0 #1624

Merged
merged 1 commit into from Oct 22, 2022
Merged

deps: update to windows-sys 0.42.0 #1624

merged 1 commit into from Oct 22, 2022

Conversation

poliorcetics
Copy link
Contributor

windows-sys 0.42.0 was released some time ago and should break neither MSRV nor public API
(I hope).

@poliorcetics
Copy link
Contributor Author

poliorcetics commented Oct 20, 2022

Strangely running cargo check --all-targets --target x86_64-pc-windows-msvc did not raise the errors caught by CI, I wonder why

EDIT: Ah, I did not pass the necessary features flag

@Thomasdezeeuw
Copy link
Collaborator

@poliorcetics You can use make check_all_targets, possibly requiring make install_target, or use the command it uses with the correct target set.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, it shouldn't break anything looking at the CI. Unfortunately windows-sys doesn't seem to keep a changelog, but looking at microsoft/windows-rs@0.36.0...0.42.0 it seems ok.

@Thomasdezeeuw Thomasdezeeuw merged commit c6cc563 into tokio-rs:master Oct 22, 2022
@Thomasdezeeuw
Copy link
Collaborator

Thanks @poliorcetics

@poliorcetics poliorcetics deleted the windows-sys-0.42.0 branch October 24, 2022 06:41
@poliorcetics
Copy link
Contributor Author

@Thomasdezeeuw is releasing a new patch version possible ? Are there other changes in master that would preclude that ?

@Thomasdezeeuw
Copy link
Collaborator

See #1625, I think I can do that later today.

@poliorcetics
Copy link
Contributor Author

Thank you very much !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants