Add GitHub Actions #1598
Add GitHub Actions #1598
Conversation
Should move over all of the Azure CI checks.
Adds: * arm-linux-androideabi * i686-unknown-linux-gnu * x86_64-apple-ios * x86_64-unknown-redox Since we use this in GitHub Actions we'll need to match the targets of Azure CI.
Required due to the use of -Zminimal-versions.
The performance of it doesn't really matter much.
|
@Noah-Kennedy what do you think about the checking all the targets in separate steps (like for Azure) vs in one step (like the |
|
I like the CheckTargets step. |
|
@Thomasdezeeuw we will need to have someone with perms set the required status checks in GitHub to be the actions versions, not the azure versions. |
|
Also, you should add a job like tokio does that acts as the only needed status check, which simply depends on all other jobs to pass: https://github.com/tokio-rs/tokio/blob/master/.github/workflows/ci.yml#L32 |
I got those permission.
You mean only make that single job required? |
excellent
Yes, this way we don't need you to manually add or remove status checks every time they change, we can just handle this through the normal PR process. |
This will be the only job required to succeed to merge a pr.
Moved to GitHub Actions.
|
I'm removing the deploy docs action: https://github.com/tokio-rs/mio/blob/4532c424dc9f8f28c6ff1f21e7ea2f911f8dd98b/ci/azure-deploy-docs.yml, I don't think it's used anymore as we moved to https://docs.rs/mio. |
No description provided.