net: add SO_LINGER option for TcpStream #1402
Conversation
| /// When set, the closing/shutting down of the socket will not return | ||
| /// until all queued messages for the socket have been successfully | ||
| /// sent or the linger timeout has been reached. | ||
| pub fn set_linger(&self, dur: Option<Duration>) -> io::Result<()> { |
There was a problem hiding this comment.
I think we should stick to the same API as std lib.
There was a problem hiding this comment.
So for tokio::net TcpStream @carllerche mentioned to me the plan was to follow std lib's api but it was abandoned.
I assumed we want mio's TcpStream to be similar to tokio's.
If we only add From traits here then we'd still have to have deal with ManuallyDrop at tokio TcpStream layer.
There was a problem hiding this comment.
@Thomasdezeeuw what is the std lib API? I don't see one? Could you clarify what API you mean?
There was a problem hiding this comment.
@carllerche that is my point. Not having set_linger on TcpStream.
| /// When set, the closing/shutting down of the socket will not return | ||
| /// until all queued messages for the socket have been successfully | ||
| /// sent or the linger timeout has been reached. | ||
| pub fn set_linger(&self, dur: Option<Duration>) -> io::Result<()> { |
There was a problem hiding this comment.
@carllerche that is my point. Not having set_linger on TcpStream.
| @@ -334,6 +334,20 @@ impl Drop for TcpSocket { | |||
| } | |||
| } | |||
|
|
|||
| impl From<&TcpStream> for TcpSocket { | |||
| fn from(stream: &TcpStream) -> TcpSocket { | |||
There was a problem hiding this comment.
If drop the TcpSocket now it will close the TcpStream's file descriptor. Can't use From<&TcpStream>.
There was a problem hiding this comment.
This could work with something like socket2's SockRef: https://github.com/rust-lang/socket2/blob/9c4a404d5e44df1ecc56d62d35ee22109a886b5f/src/sockref.rs#L59. Maybe it's best to wait for #1381, which I'll work on (likely) next year.
|
Closing this as we're going to follow the standard library API. We can revisited this once In the mean time the socket2 crate can be used for this. |
It was requested in a tokio PR that Mio TcpStream support setting linger option. This is so that the logic for converting a mio TcpStream into a TcpSocket stays within mio.