Add unix::pipe #1356
Merged
Add unix::pipe #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This adds 189 lines of code (381 total) in |
|
These feature matrices are getting out hand.. we're up to 65 (!) combinations now. |
carllerche
approved these changes
Oct 23, 2020
Adds one new function: unix::pipe, which is a wrapper around the pipe(2) system call, and two new types: Sender and Receiver, wrappers around the file descriptors. This is a port of https://github.com/Thomasdezeeuw/mio-pipe, commit 8c3025edf128e90733e95327d88493887b93fcdd.
Found by Clippy.
Currently we support 1.39 as minimum version, the `matches!` macro it's suggesting has only been stable since 1.42.
Before it would only do so when one of the net feature was enabled, but the pipe feature also uses it.
Exporting pipe::Sender, pipe::Receiver and pipe::new, removing unix::Sender, unix::Receiver and unix::pipe.
Thomasdezeeuw
force-pushed
the
mio-pipe
branch
from
3956025
to
cdda25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds one new function: unix::pipe, which is a wrapper around the pipe(2)
system call, and two new types: Sender and Receiver, wrappers around the
file descriptors.
This is a port of https://github.com/Thomasdezeeuw/mio-pipe, commit
8c3025edf128e90733e95327d88493887b93fcdd.
Closes #1354.