Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move Mio-pipe into Mio #1354

Closed
Thomasdezeeuw opened this issue Sep 29, 2020 · 1 comment · Fixed by #1356
Closed

Proposal: move Mio-pipe into Mio #1354

Thomasdezeeuw opened this issue Sep 29, 2020 · 1 comment · Fixed by #1356
Labels
rfc Request for comments.

Comments

@Thomasdezeeuw
Copy link
Collaborator

The Mio-pipe crate provides a simple wrapper around a Unix pipe. It's currently ~300 lines of code, but I think that can be reduced if it's lives inside the Mio repo, mainly by using IoSource.

One current disadvantage is that it doesn't have Windows support. But @carllerche has been working on that in #1351.

Source: https://github.com/Thomasdezeeuw/mio-pipe
Docs: https://docs.rs/mio-pipe/0.1.1/mio_pipe

@Thomasdezeeuw Thomasdezeeuw added the rfc Request for comments. label Sep 29, 2020
@carllerche
Copy link
Member

Sounds good to me. I might call the fn pipe() instead of new_pipe(), but that is minor. It can live in mio::unix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc Request for comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants