implement client set #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/client-set
branch
from
1e035d1
to
5397a54
Compare
EverlastingBugstopper
force-pushed
the
avery/tracing
branch
from
7ac755b
to
3414827
Compare
EverlastingBugstopper
force-pushed
the
avery/tracing
branch
from
3414827
to
928da11
Compare
still work to be done here but it's a start. right now this commit contains logic to handle `cargo run --bin client set key value` and nothing else
EverlastingBugstopper
force-pushed
the
avery/client-set
branch
from
5397a54
to
0d29559
Compare
EverlastingBugstopper
force-pushed
the
avery/tracing
branch
2 times, most recently
from
eda7343
to
2b6b19e
Compare
carllerche
reviewed
Mar 25, 2020
src/cmd/set.rs
Outdated
| @@ -50,4 +67,12 @@ impl Set { | |||
| debug!(?response); | |||
| dst.write_frame(&response).await | |||
| } | |||
|
|
|||
| pub(crate) fn get_frame(self) -> Frame { | |||
There was a problem hiding this comment.
Idiomatically, this probably should be named into_frame.
carllerche
reviewed
Mar 25, 2020
src/client.rs
Outdated
| unimplemented!(); | ||
| pub async fn set(&mut self, opts: Set) -> io::Result<()> { | ||
| let frame = Command::Set(opts).to_frame()?; | ||
| self.conn.write_frame(&frame).await |
There was a problem hiding this comment.
I guess we probably should validate the response?
EverlastingBugstopper
force-pushed
the
avery/client-set
branch
from
eabf670
to
850462e
Compare
carllerche
reviewed
Mar 26, 2020
| "unexpected response from server", | ||
| )); | ||
| if let Some(response) = response { | ||
| match response { |
There was a problem hiding this comment.
We probably want to have a fn that tries to convert a frame into the various types. Then you can do response.try_into_string() or something like that.
There was a problem hiding this comment.
interesting thought - seems probably worth a separate PR
carllerche
reviewed
Mar 26, 2020
src/client.rs
Outdated
| Ok(self.conn.write_frame(&frame).await?) | ||
| self.conn.write_frame(&frame).await?; | ||
| let response = self.conn.read_frame().await?; | ||
| let unknown_error = Box::new(Error::new( |
There was a problem hiding this comment.
We want to avoid unconditionally allocating here.
carllerche
reviewed
Mar 26, 2020
src/client.rs
Outdated
| if response == "OK" { | ||
| Ok(()) | ||
| } else { | ||
| Err(unknown_error) |
There was a problem hiding this comment.
Suggested change
| Err(unknown_error) | |
| Err("unexpected response from server".into()) |
This should work. The error message could be set to a const too to avoid duplicating it.
There was a problem hiding this comment.
👍 TIL!
carllerche
approved these changes
Mar 28, 2020
carllerche
added a commit
that referenced
this pull request
Mar 30, 2020
Continuation of #11. Refines the client structure and implements GET. `clap` is decoupled from the lib code. This is done to avoid any CLI parsing concerns to leak into the lib. The main motivation for this is to allow the reader to focus on Tokio concerns and not CLI parsing concerns.
Merged
carllerche
added a commit
that referenced
this pull request
Apr 1, 2020
Continuation of #11. Refines the client structure and implements GET. `clap` is decoupled from the lib code. This is done to avoid any CLI parsing concerns to leak into the lib. The main motivation for this is to allow the reader to focus on Tokio concerns and not CLI parsing concerns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still work to be done here but it's a start. right now this commit
contains logic to handle
cargo run --bin client set key valueandnothing else
TODO:
i have an open question about usage and specifying EX/PX here, and still need to send the proper frames when our duration argument is sent