Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the upload-bins github actions step on release #489

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gyfis
Copy link

@gyfis gyfis commented Nov 11, 2023

Skip creating the release, since taiki-e/create-gh-release-action is not compatible with the Changelog format

@gyfis gyfis requested a review from a team as a code owner November 11, 2023 08:15
@hds
Copy link
Collaborator

hds commented Nov 16, 2023

@gyfis Thanks for your PR! I need to have a bit of a look at it, as ideally we'd replace this step with creating a release in a different way and I'd prefer to have this still in the code until then (it's a sort of marker of intent, even if it doesn't work).

@gyfis
Copy link
Author

gyfis commented Nov 20, 2023

Hi @hds, thanks! Looking at the release page it seems that releases are being done fine https://github.com/tokio-rs/console/releases so I'd hope this change would hook right into the new approach (introduced here #466).

@hds
Copy link
Collaborator

hds commented Nov 20, 2023

@gyfis The new approach only pushes a commit and a tag, it doesn't create the GitHub release. If you check closely, you'll see that the latest releases in GitHub aren't the latest ones on crates.io (we're missing the latest one release for all 3 crates).

@gyfis
Copy link
Author

gyfis commented Nov 20, 2023

I see now, thanks! Gotcha, it'd be ideal to unify 😅 that's out of scope for me I'm afraid, feel free to close this PR (or I can do that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants