Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce is_inline calls in Bytes's BufMut impl #82

Closed
wants to merge 1 commit into from
Closed

Reduce is_inline calls in Bytes's BufMut impl #82

wants to merge 1 commit into from

Conversation

carllerche
Copy link
Member

@carllerche carllerche commented Mar 19, 2017 •
edited

Fixes #81

@carllerche
Copy link
Member Author

We'll probably not want to merge this as is, and instead to a more systematic review of the BytesMut fns.

@carllerche carllerche mentioned this pull request Apr 5, 2017
Merged
@arthurprs
Copy link
Contributor

Maybe this should be merged?

@carllerche
Copy link
Member Author

Well, this isn't super critical and I was hoping to do a more systematic pass / optimization.

@seanmonstar
Copy link
Member

This is no longer relevant.

@seanmonstar seanmonstar deleted the bytes-perf-tweaks branch October 16, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BytesMut's BufMut impl is much slower than Vec's
3 participants
@carllerche @arthurprs @seanmonstar