Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse capacity when possible in <BytesMut as Buf>::advance impl #698

Merged
merged 1 commit into from Apr 25, 2024
Merged

Reuse capacity when possible in <BytesMut as Buf>::advance impl #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/bytes_mut.rs
View file
Open in desktop
Expand Up @@ -1066,6 +1066,14 @@ impl Buf for BytesMut {

#[inline]
fn advance(&mut self, cnt: usize) {
// Advancing by the length is the same as resetting the length to 0,
// except this way we get to reuse the full capacity.
if cnt == self.remaining() {
// SAFETY: Zero is not greater than the capacity.
unsafe { self.set_len(0) };
return;
}

assert!(
cnt <= self.remaining(),
"cannot advance past `remaining`: {:?} <= {:?}",
Expand Down