Don't set len in BytesMut::reserve
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fundamental invariant of `reserve` is that it can extend capacity while the stored data remains the same, even if it's moved to a new allocation. As a result, `len` can never change during a call to `reserve`.
Darksonn
reviewed
Apr 8, 2024
| @@ -639,7 +639,6 @@ impl BytesMut { | |||
|
|
|||
| // Update the info | |||
| self.ptr = vptr(v.as_mut_ptr().add(off)); | |||
| self.len = v.len() - off; | |||
There was a problem hiding this comment.
How about asserting that they are equal?
debug_assert_eq!(self.len, v.len() - off);There was a problem hiding this comment.
Works for me! Added in f92c9f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fundamental invariant of
reserveis that it can extend capacity while the stored data remains the same, even if it's moved to a new allocation. As a result,lencan never change during a call toreserve.