Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore commented tests #665

Merged
merged 2 commits into from Feb 6, 2024
Merged

Conversation

braddunbar
Copy link
Contributor

These seem to have been commented by accident in #298, and are still passing. All of the functionality under test here seems to still be relevant.

These seem to have been commented by accident in tokio-rs#298, and are still
passing.
No need to build these in dev/release mode.
@braddunbar
Copy link
Contributor Author

Added one more commit to move them into a tests module.

Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carllerche carllerche merged commit 8bcac21 into tokio-rs:master Feb 6, 2024
15 checks passed
@braddunbar braddunbar mentioned this pull request Mar 22, 2024
@braddunbar braddunbar deleted the uncomment-tests branch March 24, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants