Rename UninitSlice constructors for consistency with ReadBuf #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Feb 11, 2023
Darksonn
reviewed
Feb 12, 2023
mina86
commented
Jun 17, 2023
tokio::io::ReadBuf uses names `new` and `uninit` for its constructors. For consistency with that, rename recently introduced UninitSlice constructors to match those names.
Darksonn
reviewed
Jun 19, 2023
Comment on lines
-40
to
39
| pub fn from_uninit_slice(slice: &mut [MaybeUninit<u8>]) -> &mut UninitSlice { | ||
| unsafe { &mut *(slice as *mut [MaybeUninit<u8>] as *mut UninitSlice) } | ||
| } | ||
|
|
||
| fn from_uninit_slice_ref(slice: &[MaybeUninit<u8>]) -> &UninitSlice { | ||
| unsafe { &*(slice as *const [MaybeUninit<u8>] as *const UninitSlice) } | ||
| pub fn new(slice: &mut [u8]) -> &mut UninitSlice { | ||
| unsafe { &mut *(slice as *mut [u8] as *mut [MaybeUninit<u8>] as *mut UninitSlice) } | ||
| } | ||
|
|
There was a problem hiding this comment.
I guess the only reason this isn't a breaking change is that we haven't yet released the from_uninit_slice method.
There was a problem hiding this comment.
Right. v1.4.0 had only from_raw_parts_mut public constructor and
it’s not changed. from_slice is changed but it’s pub(crate) so it
doesn’t affect the API.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokio::io::ReadBuf uses names
newanduninitfor itsconstructors. For consistency with that, rename recently
introduced UninitSlice constructors to match those names.