Make advance_mut impl of BufMut for Vec<u8> panic if cnt > remaining #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if cnt > remaining
|
I'm neutral on this. I don't think it is necessarily a breaking change as the fn is documented to say that panics can happen. On the other hand, the change isn't critical imo. The fn is already flagged as So, I could go either way. @seanmonstar ? |
|
Oh, if we don't merge this now, we probably should for the next breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #354.
As suggested here, this PR goes the route of making
advance_mutforVec<u8>panic ifcnt>remaining. That's definitely a breaking change: Any consumers that expectsome_vec.advance_mut(cnt)to reserve space will need to reserve it themselves in advance instead.