Make freeze respect the start offset for BytesMuts in Vec mode #376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #352. This one seemed pretty straightforward to me (advance the
Bytes
before returning). But I'm a Rust newbie, so let me know if I'm missing something.Also, I guess this is technically a breaking change b/c consuming code might have been depending on the old behavior. E.g. something like
Y'all's call on how big of a concern that is. My thought is it seems small: The work around above seems less likely than the workaround of using
split_to
as mentioned in the original issue. And the old behavior definitely seemed inconsistent (behavior for Vec mode differed from the behavior for Arc mode, and behavior forfreeze
differed from the behavior foras_slice
/as_slice_mut
).