Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response::ErrorResponse and response::Result #921

Merged
merged 8 commits into from
Apr 21, 2022
Merged

Add response::ErrorResponse and response::Result #921

merged 8 commits into from
Apr 21, 2022

Commits on Apr 8, 2022

  1. feat: add response::{Error, Result} 

    This type makes for efficient use of the `?` operator when in a function
with multiple return error types that all implement `IntoResponse`.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
    @npmccallum
    npmccallum committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    0278b9a View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. misc adjustments from PR review

    @davidpdrsn
    davidpdrsn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    63aaa3a View commit details
    Browse the repository at this point in the history

  2. Rename to ErrorResponse and ResultResponse

    @davidpdrsn
    davidpdrsn committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    8b324c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. nitpicky docs changes

    @davidpdrsn
    davidpdrsn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    fa0e886 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into error2

    @davidpdrsn
    davidpdrsn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    8398911 View commit details
    Browse the repository at this point in the history

  3. update changelog

    @davidpdrsn
    davidpdrsn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    054d924 View commit details
    Browse the repository at this point in the history

  4. changelog wording

    @davidpdrsn
    davidpdrsn committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    3976b87 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Jonas Platte <jplatte+git@posteo.de>
    @davidpdrsn @jplatte
    davidpdrsn and jplatte committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    56137a7 View commit details
    Browse the repository at this point in the history