Feature: Serve::tcp_nodelay
#2653
Conversation
|
Hi, this looks good to me. Can you just add an entry to the changelog please? |
axum/src/serve.rs
Outdated
|
|
||
| /// Instructs the server to set the value of the `TCP_NODELAY` option on every accepted connection. | ||
| /// | ||
| /// See also [`TcpStream::set_nodelay`] |
There was a problem hiding this comment.
| /// See also [`TcpStream::set_nodelay`] | |
| /// See also [`TcpStream::set_nodelay`]. |
axum/src/serve.rs
Outdated
| impl<M, S, F> WithGracefulShutdown<M, S, F> { | ||
| /// Instructs the server to set the value of the `TCP_NODELAY` option on every accepted connection. | ||
| /// | ||
| /// See also [`TcpStream::set_nodelay`] |
There was a problem hiding this comment.
| /// See also [`TcpStream::set_nodelay`] | |
| /// See also [`TcpStream::set_nodelay`]. |
The idea was that there is maybe some configuration or OS where it could be enabled by default that I'm just not aware of. Just wanted to make sure that we don't mess with that default value and users can explicitly disable it. Again, I personally couldn't give you an example of such an OS or config. ("[..] On Mac OS there was no difference in performance between The comment doesn't imply that its not enabled tho. |
|
Hey, I'll try to get to this again soon. Your reasoning for having the bool parameter makes sense, let's keep that. |
jplatte
added
the
S-waiting-on-author
Fixes: #2521
Motivation
See #2521 and linked issue in hyper
Solution
Adds the
tcp_nodelaymethod toServe(andWithGracefulShutdown) to enable the user to instruct the server to setTCP_NODELAYon incoming connections.Regarding tests: I wasn't really sure what you would like to have there (since
with_graceful_shutdownalso doesn't seem to have tests or I didn't find them, not sure), so pointers are appreciated.