Added MongoDB example #2535
Open
Added MongoDB example #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
reviewed
Feb 11, 2024
examples/mongodb/src/main.rs
Outdated
| // defining Member type | ||
| #[derive(Debug, Deserialize, Serialize)] | ||
| struct Member { | ||
| _id: u32, |
There was a problem hiding this comment.
Why the _?
Suggested change
| _id: u32, | |
| id: u32, |
There was a problem hiding this comment.
I believe this is because MongoDB uses the _id field as primary key.
Maybe it could be #[serde(rename = "_id")] id: u32 to adhere to Rust's convention?
examples/mongodb/src/main.rs
Outdated
| Json(input): Json<Member>, | ||
| ) -> impl IntoResponse { | ||
| let result = db.insert_one(input, None).await.unwrap(); | ||
| println!("{:?}", result); |
There was a problem hiding this comment.
Not sure we need all this print. Same goes for the ones below.
Suggested change
| println!("{:?}", result); |
examples/mongodb/src/main.rs
Outdated
| async fn create_member( | ||
| State(db): State<Collection<Member>>, | ||
| Json(input): Json<Member>, | ||
| ) -> impl IntoResponse { |
There was a problem hiding this comment.
We generally don't recommend returning impl IntoResponse, see https://docs.rs/axum/latest/axum/response/index.html#regarding-impl-intoresponse.
So I think instead we should write the full type.
Would also be good to not unwrap inside the handler and instead return a Result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! ^^
Motivation
Recently, I've been trying to create an API service in
Rustto communicate with MongoDB usingaxum. Adding an example would be nice for future developers.Solution
examples/mongodb.