Ensure we include the port when parsing authority #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @bouk long time no see! (we worked together very briefly a few years ago) What a coincidence that you would open your first PR here just before I open my first PR :) One suggestion I have here is to add a test case to validate the split you are doing on |
|
Hey @waynr! Good suggestion, added another test case |
davidpdrsn
reviewed
Oct 1, 2023
|
Added it to the changelog |
|
maybe also add a link to the rfc in the code comment ? https://www.rfc-editor.org/rfc/rfc9110.html#name-host-and-authority |
bouk
force-pushed
the
bouk/extract-host-from-uri-port
branch
from
3c141be
to
ed7d490
Compare
|
I've rebased to latest main and updated the comment to link to the RFC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The 'Host' header should include the port number. When extracting the host from
uriwe useuri.host()however, which strips off the port number to only include the hostname.The existing test also didn't test the right thing, because the request would still include a Host header—it's added automatically by
hyperand there's no way to turn that off from reqwest.Solution
Re-implement the authority parsing method directly. This code is copied from the
httpcrate, just without the port stripping: https://github.com/hyperium/http/blob/1a04e715f49c9ac3fe8195583e8c9959cbd368d3/src/uri/authority.rs#L487-L505