Add FixNestedRedirect middleware
#2230
Conversation
This adds `FixNestedRedirectLayer` which uses `NestedPath` to change redirects from nested services to include the path they're nested at. Fixes #1731
|
Wouldn't it be better to fix this in tower-http? |
That would require moving axum's
|
|
Converting to draft because I just remember that this (and |
There was a problem hiding this comment.
I'm a bit surprised this is in axum as opposed to axum-extra. There seem to be quite a few design choices to be made, for instance I would not have thought of including FixNestedRedirectOptOut, but I was wondering whether there could be problems with people applying the middleware multiple times redundantly (more / less nested); if we wanted to solve this having extract remove the NestedPath or insert some other extension do tell that the middleware ran already could work?
| @@ -45,6 +45,13 @@ impl NestedPath { | |||
| pub fn as_str(&self) -> &str { | |||
| &self.0 | |||
| } | |||
|
|
|||
| pub(crate) fn extract(parts: &mut Parts) -> Result<Self, NestedPathRejection> { | |||
There was a problem hiding this comment.
| pub(crate) fn extract(parts: &mut Parts) -> Result<Self, NestedPathRejection> { | |
| pub(crate) fn extract(parts: &Parts) -> Result<Self, NestedPathRejection> { |
| return Some(()); | ||
| } | ||
|
|
||
| let nested_path = nested_path?; |
There was a problem hiding this comment.
This seems like it could be done earlier.
I wouldn't add NestedPath to tower-http, but give If |
Yeah I considered putting it in axum-extra. That probably is the better path. I'll move it.
I think I'll move forward with the path in this PR and then see what happens as people use it and give feedback. |
This adds
FixNestedRedirectLayerwhich usesNestedPathto change redirects from nested services to include the path they're nested at.Fixes #1731