Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KeepAlive::event #1729

Merged
merged 4 commits into from Feb 23, 2023
Merged

Add KeepAlive::event #1729

merged 4 commits into from Feb 23, 2023

Conversation

davidpdrsn
Copy link
Member

Fixes #1728

@markuskobler what do you think about this?

@markuskobler
Copy link

👍 works great thanks!

@davidpdrsn
Copy link
Member Author

@jplatte gentle ping :)

jplatte
jplatte approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebSockets and (esp.) SSE are things I don't know much about but I guess this looks fine.

@davidpdrsn davidpdrsn enabled auto-merge (squash) February 23, 2023 13:10
@davidpdrsn davidpdrsn merged commit 2cbaa63 into main Feb 23, 2023
@davidpdrsn davidpdrsn deleted the sse-keep-alive-event branch February 23, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte jplatte approved these changes

Assignees
No one assigned
Labels
A-axum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose futher SSE KeepAlive event customization
3 participants
@davidpdrsn @markuskobler @jplatte