Skip to content

Add RawPathParams #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2023
Merged

Add RawPathParams #1713

merged 4 commits into from
Jan 20, 2023
+159 −6

Conversation

davidpdrsn
Copy link
Member

For library authors that are building on top of axum it might be useful to get the raw path parameters, without deserializing, and thus saving some allocations.

@davidpdrsn davidpdrsn marked this pull request as ready for review January 20, 2023 16:40
jplatte
jplatte approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good idea!

@davidpdrsn
Copy link
Member Author

Credit goes to @carllerche for this idea :)

@davidpdrsn davidpdrsn enabled auto-merge (squash) January 20, 2023 20:32
@davidpdrsn davidpdrsn merged commit 5b07296 into main Jan 20, 2023
@davidpdrsn davidpdrsn deleted the path-params branch January 20, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplatte jplatte

Assignees
No one assigned
Labels
A-axum
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidpdrsn @jplatte