Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback inheritance, attempt 2 #1531

Closed
wants to merge 1 commit into from

Conversation

davidpdrsn
Copy link
Member

@davidpdrsn davidpdrsn commented Nov 15, 2022

@jplatte
Copy link
Member

jplatte commented Nov 18, 2022

After looking at it for a bit, I'm pretty sure this can be made to work if Map stores the fallback alongside the layer and applies it later. I think that applying later thing "just" needs an extra interface somewhere. I also think this would be a little easier to design if at least at first boxed handlers and boxed routers were separate. I can try to find some time for a third attempt at this problem, if you think more internal complexity is acceptable.

@davidpdrsn
Copy link
Member Author

That'd be great! I don't mind the additional complexity. Having used the current boxed handler stuff in anger now I feel I understand it better 😊

How do you feel about merging #1521 as is (using extensions) and then changing the internals later? Both approaches would have the same public api I suppose.

@jplatte
Copy link
Member

jplatte commented Nov 18, 2022

Yeah, let's do that.

@davidpdrsn
Copy link
Member Author

Closing in favor of #1521

@davidpdrsn davidpdrsn closed this Nov 18, 2022
@davidpdrsn davidpdrsn deleted the fallback-inheritance-attempt-2 branch November 18, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants