Relax bounds for FromExtractor
#1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1467 We didn't actually use the bounds. I guess they were left over from a previous version.
jplatte
approved these changes
Oct 10, 2022
|
Thank you very much for the quick fix ❤️ Would it be possible to get a |
|
The bounds are actually being used on 0.5 so would require more work to backport, so since 0.6 is quite far along I'd rather no backport it. Once #1462 is merged I'm gonna do another 0.6 rc with this change and then you can use that, assuming that you're able to use 0.6 in the first place. Otherwise your best bet is probably not to use |
|
All right, sounds good. The 0.6 features look really nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't actually use the bounds. I guess they were left over from a previous version.
Fixes #1467