Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accidental breaking change to FailedToDeserializeQueryString #1233

Merged
merged 1 commit into from Aug 9, 2022

Conversation

davidpdrsn
Copy link
Member

Fixes #1202

I'll update the changelogs, with notes about why 0.5.14 was yanked, in
the release PR.

Fixes #1202

I'll update the changelogs, with notes about why 0.5.14 was yanked, in
the release PR.
@@ -67,7 +67,7 @@ where
if req.method() == Method::GET {
let query = req.uri().query().unwrap_or_default();
let value = serde_html_form::from_str(query)
.map_err(FailedToDeserializeQueryString::__private_new)?;
.map_err(FailedToDeserializeQueryString::__private_new::<(), _>)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, why is this () instead of T?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that assuming this is released, and the new axum-extra is used with an older version of axum, the message will still include "for type _", but _ will be ().

I guess we can release the new axum 0.5.x release, then update axum-extra's dependency so it has a matching minimum version, and release that 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can release the new axum 0.5.x release, then update axum-extra's dependency so it has a matching minimum version, and release that

Yeah that was my plan.

@davidpdrsn davidpdrsn merged commit 3215709 into 0.5.x Aug 9, 2022
@davidpdrsn davidpdrsn deleted the fix-form-rejection-breakage branch August 9, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants