Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship new version of axum and axum-extra #1202

Closed
davidpdrsn opened this issue Jul 27, 2022 · 5 comments
Closed

Ship new version of axum and axum-extra #1202

davidpdrsn opened this issue Jul 27, 2022 · 5 comments
Labels
A-axum A-axum-extra

Comments

@davidpdrsn
Copy link
Member

davidpdrsn commented Jul 27, 2022 •
edited

We accidentally shipped #1171 in a minor version which included a breaking change in axum but didn't merge a new version of axum-extra so axum-extra broke.

I've yanked axum 0.5.14 so no one can update to it.

I'll ship a new version of axum and axum-extra (that depends on the version of axum) in a week from today.
@jplatte
Copy link
Member

jplatte commented Jul 27, 2022

Actually, we can't just ship both as non-breaking, since people could upgrade to the new version of axum without upgrading axum-extra. We'll have to backport #1171 in a way that doesn't change the number of type parameters, or have it wait until axum 0.6.

@rsilvestre rsilvestre mentioned this issue Jul 28, 2022
Merged
@Xuanwo
Copy link

Xuanwo commented Aug 5, 2022

Any updates on this? We have to work around to make cargo audit happy: datafuselabs/databend#6996

@davidpdrsn
Copy link
Member Author

Not yet. I've been on vacation. ETA is sometime this week.

@Xuanwo
Copy link

Xuanwo commented Aug 5, 2022

Not yet. I've been on vacation. ETA is sometime this week.

Oh, sorry for disturbing your vacation. Have a nice day!

davidpdrsn added a commit that referenced this issue Aug 9, 2022
@davidpdrsn
Fix accidental breaking change to FailedToDeserializeQueryString
b8b8358 
Fixes #1202

I'll update the changelogs, with notes about why 0.5.14 was yanked, in
the release PR.
@davidpdrsn davidpdrsn mentioned this issue Aug 9, 2022
Merged
davidpdrsn added a commit that referenced this issue Aug 9, 2022
@davidpdrsn
Fix accidental breaking change to FailedToDeserializeQueryString (#…
3215709 
…1233)

Fixes #1202

I'll update the changelogs, with notes about why 0.5.14 was yanked, in
the release PR.
@davidpdrsn
Copy link
Member Author

This was fixed in #1233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-axum A-axum-extra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidpdrsn @jplatte @Xuanwo