Renaming: Add .sh extension to completion script #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't matter if (as currently recommended) the script is placed into a eagerly loaded location (like
/etc/bash_completion.d/
) - any name will do.However, there's now lazy loading of completion scripts (in
/usr/share/bash-completion/completions/
), and that only works when the completion script is named exactly like the command the completion is for. As our command istodo.sh
(ignoring aliases, which become more complex with lazy loading), the corresponding completion needs to betodo.sh
(with the.sh
extension) as well. Renaming does not do any harm for our recommended location, but makes it easier for users (and packagers who prepare a todo.sh package) that want to use lazy loading.See #383 for the complete discussion.
Before submitting a pull request, please make sure the following is done:
master
.fixes #XX
reference to the issue that this pull request fixes.