Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GC profiling timing #214

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Fix GC profiling timing #214

merged 1 commit into from
Jul 12, 2023

Commits on Jul 11, 2023

  1. Fix GC profiling timing 

    We were recording GC profile timestamps inside the VM postponed job that
flushes temporary information.  The postponed job could be run much
later than the sample was actually taken, so this commit records a
timestamp in the signal handler when there is a GC event.

It only records one time stamp, so if there are multiple GC events in a
row, we have to assume that the total duration spent in GC starts from
the first time stamp and extends until the timestamp of the next non-GC
sample.  In other words, we don't record a correct timestamp for each GC
sample, only the first one.
    @tenderlove
    tenderlove committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    329e57b View commit details
    Browse the repository at this point in the history