Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert StackProf.run / StackProf.result to Ruby #154

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Convert StackProf.run / StackProf.result to Ruby #154

wants to merge 6 commits into from

Commits on Feb 22, 2023

  1. Convert StackProf.run / StackProf.result to Ruby 

    This commit is kind of a yak shave.  I would like to add thread tracking
to stackprof.  I want to allow people to optionally dump the thread for
which the stack was collected on by doing `StackProf.result(threads: true)`
Updating the signature for `result` was kind of hard, so I am
refactoring it to be in Ruby.

This commit technically breaks the case of someone doing:

```ruby
StackProf.start(out: "some_file.data")
...
StackProf.result
```

But I think it's strange to ask the start function to dump the file
rather than asking the result function.  The result function actually
writes to the file, so I think it makes more sense to pass the file (or
file name) to the result function.
    @tenderlove
    tenderlove committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    86622c8 View commit details
    Browse the repository at this point in the history

  2. run the build

    @tenderlove
    tenderlove committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    9c36791 View commit details
    Browse the repository at this point in the history

  3. testing

    @tenderlove
    tenderlove committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    bf4167e View commit details
    Browse the repository at this point in the history

  4. testing

    @tenderlove
    tenderlove committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0b05968 View commit details
    Browse the repository at this point in the history

  5. I don't want to support this many Ruby versions

    @tenderlove
    tenderlove committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    8cd73fa View commit details
    Browse the repository at this point in the history

  6. testing

    @tenderlove
    tenderlove committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    70f3910 View commit details
    Browse the repository at this point in the history