Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect stack frames immediately in Ruby 3.0 #150

Merged
merged 3 commits into from Apr 29, 2021
Merged

Collect stack frames immediately in Ruby 3.0 #150

merged 3 commits into from Apr 29, 2021

Commits on Apr 28, 2021

  1. Remove reentrancy detection from postponed job 

    Because this is in the postponed job handler, we should never be able to
reenter this code.

I also believe this has a race condition if another signal arrives
between the if statement and the increment. Signals can also arrive in
any thread so this would not be a safe way to avoid reentrancy.
    @jhawthorn
    jhawthorn committed Apr 28, 2021
    Copy the full SHA
    415ee28 View commit details
    Browse the repository at this point in the history

  2. Use a mutex to avoid reentering signal handler 

    This entures we won't re-enter the signal handler from another signal
whether or not it happens in our own thread.
    @jhawthorn
    jhawthorn committed Apr 28, 2021
    Copy the full SHA
    cf67aff View commit details
    Browse the repository at this point in the history

  3. Collect stack frames immediately on interrupt 

    Co-authored-by: Aaron Patterson <aaron.patterson@gmail.com>
    @jhawthorn @tenderlove
    jhawthorn and tenderlove committed Apr 28, 2021
    Copy the full SHA
    6c3f4d7 View commit details
    Browse the repository at this point in the history