Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert breaking change of reselect dependency update #446

Merged
merged 1 commit into from Apr 18, 2024

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Apr 18, 2024

both glob@9 and reselect@5 dropped support for Node 16. If we want to update [this dependency] then we should ship it as a major, not a patch

#445 is where the [package was] updated

@tleunen
Copy link
Owner

tleunen commented Apr 18, 2024

@mansona hmmm Reading the changelog for glob@9, it does support Node 16 and above. For reselest@5, it doesn't specify anything but the tests here didn't break for node 16, I'm not sure why.

Are you sure it's all related to this?

@mansona
Copy link
Contributor Author

mansona commented Apr 18, 2024

Hey @tleunen you're right, glob didn't change their node support, I think I confused myself when looking into this earlier today.

The real issue is reselect because v5 is now making use of optional chaining in their dist. It's true that they are not declaring this as a Node version change but I'm assuming that's because they are expecting the code to go through a babel transform in their testing suite. You can see the issue here: https://github.com/embroider-build/ember-auto-import/actions/runs/8741674479/job/23988288576?pr=620#step:6:17

node_modules/reselect/dist/cjs/reselect.cjs:166
        CURRENT_TRACKER?.add(this);
                        ^
    
    SyntaxError: Unexpected token '.'

I'm not exactly sure why your CI hasn't picked this up 🤔

@tleunen
Copy link
Owner

tleunen commented Apr 18, 2024

I see, thank you! Could you update the MR to revert only reselect then? I'll quickly throw another version

@mansona mansona changed the title revert breaking change dependency updates revert breaking change of reselect dependency update Apr 18, 2024
@mansona
Copy link
Contributor Author

mansona commented Apr 18, 2024

@tleunen updated 👍

@tleunen tleunen merged commit 8923c48 into tleunen:master Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants