Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pw-config: add page #12800

Merged
merged 4 commits into from
May 19, 2024
Merged

pw-config: add page #12800

merged 4 commits into from
May 19, 2024

Conversation

spageektti
Copy link
Member

Hi. This PR adds a page for pw-config, which is part of pipewire.
Instead of using placeholders, I used specific examples because I think they show more of what the command is about, but I will add placeholders if needed.
#11747

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): Compiled with libpipewire 1.0.6

@spageektti spageektti requested a review from cyqsimon as a code owner May 17, 2024 16:02
@github-actions github-actions bot added the new command Issues requesting creation of a new page. label May 17, 2024
kbdharun
kbdharun reviewed May 17, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/linux/pw-config.md Outdated Show resolved Hide resolved
pages/linux/pw-config.md Outdated Show resolved Hide resolved
spageektti and others added 2 commits May 17, 2024 19:00
@spageektti @kbdharun
pw-config: update description
98e9a10 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@spageektti @kbdharun
pw-config: update examples' descriptions
8972c24 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
vitorhcl
vitorhcl reviewed May 17, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

pages/linux/pw-config.md Outdated Show resolved Hide resolved
kbdharun
kbdharun approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after the above suggestion.

@spageektti @vitorhcl
pw-config: update description
53ba7db 
Co-authored-by: Vítor Henrique <87824454+vitorhcl@users.noreply.github.com>
@spageektti spageektti merged commit bdf2655 into tldr-pages:main May 19, 2024
4 checks passed
@spageektti spageektti deleted the add-pw-config-page branch May 19, 2024 19:03
@spageektti spageektti removed the request for review from cyqsimon May 19, 2024 19:16
@spageektti spageektti mentioned this pull request May 20, 2024
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhcl vitorhcl vitorhcl left review comments

@gutjuri gutjuri gutjuri approved these changes

@kbdharun kbdharun kbdharun approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spageektti @gutjuri @kbdharun @vitorhcl