Add the keys.typedmethodkey decorator
#305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 666 668 +2
=========================================
+ Hits 666 668 +2 ☔ View full report in Codecov by Sentry. |
kuraga
force-pushed
the
add-keys.typedmethodkey-decorator
branch
from
8ba973c
to
091e61e
Compare
|
Sorry for the delay, but I promise I'll look into this in more detail by the end of April, latest! |
tkem
reviewed
Apr 10, 2024
| @@ -491,7 +491,7 @@ functions with the :func:`cached` and :func:`cachedmethod` decorators: | |||
|
|
|||
| .. autofunction:: methodkey | |||
|
|
|||
| This function is equivalent to :func:`hashkey`, but ignores its | |||
| This function is similar to :func:`hashkey`, but ignores its | |||
tkem
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Reading the tests alone, this makes much more sense than previously. So 👍, thanks for your commitment (sorry for the bad joke, couldn't resist)!
|
Merged into https://github.com/tkem/cachetools/tree/dev/v5.4.0, thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #296