Fix concurrency race issue when setting values concurrently. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch resolves the issue by implementing read-write locks to protect against cache misses and prevent repeated invocations of the underlying function.
|
This seems to have fixed the issues I was running into as well albeit it runs slightly slower now due to the multiple locks |
|
@NiuBlibing Please correct me if I'm wrong, but if I understand this PR correctly, this will serialize all calls to the underlying function in case of a cache miss? No matter what their arguments are? We had PR #224 which tried to introduce "key-level locking", which AFAICS would solve this issue more cleanly, but which was rejected because of the added complexity. So, unless I completely misunderstood this, please check out #224 and explain your improvements in more detail, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch resolves the issue by implementing read-write locks to protect against cache misses and prevent repeated invocations of the underlying function.