Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cachetools.keys.typedmethodkey? #296

Open
kuraga opened this issue Feb 16, 2024 · 3 comments · May be fixed by #305
Open

cachetools.keys.typedmethodkey? #296

kuraga opened this issue Feb 16, 2024 · 3 comments · May be fixed by #305
Assignees
@tkem
Labels
enhancement

Comments

@kuraga
Copy link
Contributor

kuraga commented Feb 16, 2024

There are:

  • cachetools.keys.hashkey,
  • cachetools.keys.methodkey,
  • cachetools.keys.typedkey.

Should be there the cachetools.keys.typedmethodkey? Thanks!
@tkem
Copy link
Owner

tkem commented Feb 25, 2024

@kuraga Thnaks for the input! typedkey is used in the cachetools.func wrappers, and nobody expressed any interest in a typedmethodkey so far. For the sake of completeness, however, this might be added.

kuraga added a commit to kuraga/cachetools that referenced this issue Feb 26, 2024
@kuraga
Add the keys.typedmethodkey decorator
1d0c9fe 
Closes: tkem#296
@kuraga kuraga mentioned this issue Feb 26, 2024
Closed
@kuraga
Copy link
Contributor Author

kuraga commented Feb 26, 2024 •
edited

For the sake of completeness, however, this might be added.

Implemented in #301 #305.

kuraga added a commit to kuraga/cachetools that referenced this issue Feb 27, 2024
@kuraga
Add the keys.typedmethodkey decorator
4e26a6b 
Closes: tkem#296
kuraga added a commit to kuraga/cachetools that referenced this issue Feb 27, 2024
@kuraga
Add the keys.typedmethodkey decorator
8ba973c 
Closes: tkem#296
@kuraga kuraga linked a pull request Feb 27, 2024 that will close this issue
Open
@kuraga
Copy link
Contributor Author

kuraga commented Feb 27, 2024

New PR: #305.

kuraga added a commit to kuraga/cachetools that referenced this issue Mar 6, 2024
@kuraga
Add the keys.typedmethodkey decorator
091e61e 
Closes: tkem#296
tkem pushed a commit that referenced this issue Apr 10, 2024
@kuraga @tkem
Add the keys.typedmethodkey decorator
89c3009 
Closes: #296
tkem pushed a commit that referenced this issue May 1, 2024
@kuraga @tkem
Add the keys.typedmethodkey decorator
7637c0e 
Closes: #296
tkem pushed a commit that referenced this issue May 28, 2024
@kuraga @tkem
Add the keys.typedmethodkey decorator
f425346 
Closes: #296
tkem pushed a commit that referenced this issue Jun 2, 2024
@kuraga @tkem
Add the keys.typedmethodkey decorator
e669b99 
Closes: #296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkem tkem

Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@kuraga @tkem