Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strengthen short finish #229

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Strengthen short finish #229

merged 4 commits into from
Mar 29, 2024

Commits on Mar 29, 2024

  1. Add more tests 

    Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
    @tkaitchuck
    tkaitchuck committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    98ee5b2 View commit details
    Browse the repository at this point in the history

  2. Fix two problems with the short_finish 

    * If on ARM where the xor happens first the same value cannot be used for both parameters.
* XOR the two halfs of the output to avoid the possibility that two bit diffs can cancel

Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
    @tkaitchuck
    tkaitchuck committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6e5bfa6 View commit details
    Browse the repository at this point in the history

  3. Fix test error 

    Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
    @tkaitchuck
    tkaitchuck committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    63751e1 View commit details
    Browse the repository at this point in the history

  4. Add aarch64 nightly to github actions 

    Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
    @tkaitchuck
    tkaitchuck committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    e48298f View commit details
    Browse the repository at this point in the history