-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the MSRV presubmit checks to include multiple architectures #197
Conversation
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
https://github.com/tkaitchuck/aHash/actions/runs/7449693417/job/20266892686?pr=197#step:5:1 Seems to imply it just installed 1.60 in addition to the master build already installed Maybe you need to change cargo check --target armv7-unknown-linux-gnueabihf To explicitly mention the tool chain like cargo +1.60 check --target armv7-unknown-linux-gnueabihf FWIW we use cargo msrv to check this in datafusion |
It runs |
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
I added this, everything is still passing... |
Signed-off-by: Tom Kaitchuck <tom.kaitchuck@emc.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
It looks like it used to pass with 1.60 but then failed with 1.71 |
…197) Increase the MSRV presubmit checks to include multiple architectures Signed-off-by: Tom Kaitchuck <Tom.Kaitchuck@gmail.com>
🎉 |
No description provided.