Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #170 compile fail on aarch64 #171

Merged

Conversation

PureWhiteWu
Copy link
Contributor

fixes #170

@PureWhiteWu PureWhiteWu changed the title fix: #170 compile fail on apple silicon fix: #170 compile fail on aarch64 Oct 23, 2023
src/operations.rs Outdated Show resolved Hide resolved
src/operations.rs Outdated Show resolved Hide resolved
src/operations.rs Outdated Show resolved Hide resolved
src/operations.rs Outdated Show resolved Hide resolved
PureWhiteWu and others added 4 commits October 23, 2023 09:31
Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
@joshlf
Copy link
Contributor

joshlf commented Oct 23, 2023

If you're feeling really ambitious, maybe you could add CI jobs for arm and aarch64? @tkaitchuck would have to say whether they're interested in taking such a change, but I assume they'd be interested.

@PureWhiteWu
Copy link
Contributor Author

@joshlf Hi, I'd love to, but I'm not quite sure if github action provides aarch64 machines?

@joshlf
Copy link
Contributor

joshlf commented Oct 23, 2023

Yeah you'd probably want to cross-compile using cargo build --tests --target. You can also use cargo miri test --target to emulate tests on another target. Since this crate uses intrinsics, that might not work, but at least cross-compiling with cargo build should.

If you want to do a fuller overhaul (I'd run it by @tkaitchuck and probably do it in a different PR), you could use a job matrix like we do in zerocopy: https://github.com/google/zerocopy/blob/e2ae4f821fea88ad2a4c4ca3478cf595bef4b5f6/.github/workflows/ci.yml#L23

@PureWhiteWu
Copy link
Contributor Author

Thanks for your suggestion!
I've added aarch64-apple-darwin target in ci.

src/operations.rs Outdated Show resolved Hide resolved
src/operations.rs Outdated Show resolved Hide resolved
tkaitchuck and others added 2 commits October 23, 2023 11:18
Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
@tkaitchuck tkaitchuck merged commit 7bbbd83 into tkaitchuck:master Oct 23, 2023
8 checks passed
dignifiedquire added a commit to n0-computer/iroh that referenced this pull request Oct 23, 2023
@PureWhiteWu PureWhiteWu deleted the fix/compile_fail_on_apple_silicon branch October 24, 2023 00:52
github-merge-queue bot pushed a commit to n0-computer/iroh that referenced this pull request Oct 24, 2023
github-merge-queue bot pushed a commit to n0-computer/iroh that referenced this pull request Oct 24, 2023
dignifiedquire added a commit to n0-computer/iroh that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error on aarch64 in version 0.8.4
3 participants