Fix sphinx-doc#7785: autodoc_typehints=none does not effect to overloads

CHANGES

@@ -39,6 +39,7 @@ Bugs fixed
   typing.Generic
 * #8157: autodoc: TypeError is raised when annotation has invalid __args__
 * #7964: autodoc: Tuple in default value is wrongly rendered
+* #7785: autodoc: autodoc_typehints='none' does not effect to overloaded functions
 * #8192: napoleon: description is disappeared when it contains inline literals
 * #8142: napoleon: Potential of regex denial of service in google style docs
 * #8169: LaTeX: pxjahyper loaded even when latex_engine is not platex

sphinx/ext/autodoc/__init__.py

@@ -1240,7 +1240,9 @@ def add_directive_header(self, sig: str) -> None:
 
     def format_signature(self, **kwargs: Any) -> str:
         sigs = []
-        if self.analyzer and '.'.join(self.objpath) in self.analyzer.overloads:
+        if (self.analyzer and
+                '.'.join(self.objpath) in self.analyzer.overloads and
+                self.env.config.autodoc_typehints not in ('none', 'description')):
             # Use signatures for overloaded functions instead of the implementation function.
             overloaded = True
         else:
@@ -1475,7 +1477,9 @@ def format_signature(self, **kwargs: Any) -> str:
         overloaded = False
         qualname = None
         # TODO: recreate analyzer for the module of class (To be clear, owner of the method)
-        if self._signature_class and self._signature_method_name and self.analyzer:
+        if (self._signature_class and
+                self._signature_method_name and self.analyzer and
+                self.env.config.autodoc_typehints not in ('none', 'description')):
             qualname = '.'.join([self._signature_class.__qualname__,
                                  self._signature_method_name])
             if qualname in self.analyzer.overloads:
@@ -1874,7 +1878,9 @@ def document_members(self, all_members: bool = False) -> None:
 
     def format_signature(self, **kwargs: Any) -> str:
         sigs = []
-        if self.analyzer and '.'.join(self.objpath) in self.analyzer.overloads:
+        if (self.analyzer and
+                '.'.join(self.objpath) in self.analyzer.overloads and
+                self.env.config.autodoc_typehints not in ('none', 'description')):
             # Use signatures for overloaded methods instead of the implementation method.
             overloaded = True
         else:

tests/test_ext_autodoc.py

@@ -1948,6 +1948,54 @@ def test_final(app):
     ]
 
 
+@pytest.mark.sphinx('html', testroot='ext-autodoc',
+                    confoverrides={'autodoc_typehints': 'none'})
+def test_overload_autodoc_typehints_none(app):
+    options = {"members": None}
+    actual = do_autodoc(app, 'module', 'target.overload', options)
+    assert list(actual) == [
+        '',
+        '.. py:module:: target.overload',
+        '',
+        '',
+        '.. py:class:: Bar(x, y)',
+        '   :module: target.overload',
+        '',
+        '   docstring',
+        '',
+        '',
+        '.. py:class:: Baz(x, y)',
+        '   :module: target.overload',
+        '',
+        '   docstring',
+        '',
+        '',
+        '.. py:class:: Foo(x, y)',
+        '   :module: target.overload',
+        '',
+        '   docstring',
+        '',
+        '',
+        '.. py:class:: Math()',
+        '   :module: target.overload',
+        '',
+        '   docstring',
+        '',
+        '',
+        '   .. py:method:: Math.sum(x, y)',
+        '      :module: target.overload',
+        '',
+        '      docstring',
+        '',
+        '',
+        '.. py:function:: sum(x, y)',
+        '   :module: target.overload',
+        '',
+        '   docstring',
+        '',
+    ]
+
+
 @pytest.mark.sphinx('html', testroot='ext-autodoc')
 def test_overload(app):
     options = {"members": None}