Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change option default value type to unknown #1725

Closed
wants to merge 2 commits into from
Closed

change option default value type to unknown #1725

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d07cd
fix: change option default value type to unknown
wwwenjie May 13, 2022
c1007c5
Merge branch 'develop' into master
wwwenjie May 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions typings/index.d.ts
View file
Open in desktop
Expand Up @@ -535,21 +535,21 @@ export class Command {
*
* @returns `this` command for chaining
*/
option(flags: string, description?: string, defaultValue?: string | boolean | string[]): this;
option(flags: string, description?: string, defaultValue?: unknown): this;
option<T>(flags: string, description: string, fn: (value: string, previous: T) => T, defaultValue?: T): this;
/** @deprecated since v7, instead use choices or a custom function */
option(flags: string, description: string, regexp: RegExp, defaultValue?: string | boolean | string[]): this;
option(flags: string, description: string, regexp: RegExp, defaultValue?: unknown): this;

/**
* Define a required option, which must have a value after parsing. This usually means
* the option must be specified on the command line. (Otherwise the same as .option().)
*
* The `flags` string contains the short and/or long flags, separated by comma, a pipe or space.
*/
requiredOption(flags: string, description?: string, defaultValue?: string | boolean | string[]): this;
requiredOption(flags: string, description?: string, defaultValue?: unknown): this;
requiredOption<T>(flags: string, description: string, fn: (value: string, previous: T) => T, defaultValue?: T): this;
/** @deprecated since v7, instead use choices or a custom function */
requiredOption(flags: string, description: string, regexp: RegExp, defaultValue?: string | boolean | string[]): this;
requiredOption(flags: string, description: string, regexp: RegExp, defaultValue?: unknown): this;

/**
* Factory routine to create a new unattached option.
Expand Down