Be able to import types when using NodeNext TypeScript module resolution

[ChocolateLoverRaj]

I'm making an npm package which uses ora. To use ora, I switched to NodeNext module resolution. After doing that, the type checking for commander stopped working. I think package.json needs to be updated to be compatible with NodeNext module resolution.

Here is the guide to by the author of ora: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c.
Here is some related TypeScript documentation: https://devblogs.microsoft.com/typescript/announcing-typescript-4-5-beta/#esm-nodejs

[ChocolateLoverRaj]

I found out how to make it work: I copied typings/index.d.ts to esm.d.mts

[shadowspawn]

How are you importing Commander into your source file? e.g.

import { Command } from 'commander';

[ChocolateLoverRaj]

Creating esm.d.mts with this also works:

export * from './typings/index.js'

[ChocolateLoverRaj]

@shadowspawn I'm importing it exactly like that

[shadowspawn]

Looks like we are missing "types" entry in "exports" in package.json for (next) TypeScript.

• https://nodejs.org/dist/latest-v17.x/docs/api/packages.html#community-conditions-definitions
• https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing
• types and exports in dependency package.json break module specifier generation microsoft/TypeScript#46281

[ChocolateLoverRaj]

@shadowspawn Should I make a PR adding the "types"?

[shadowspawn]

Yes, if you like. I was about to myself, but give you first option. 😄

[shadowspawn]

Fixed in Commander v9.2.0