Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript's new moduleResolution breaks commander's typing #1773

Closed
kwasimensah opened this issue Aug 16, 2022 · 3 comments
Closed

Typescript's new moduleResolution breaks commander's typing #1773

kwasimensah opened this issue Aug 16, 2022 · 3 comments

Comments

@kwasimensah
Copy link

See microsoft/TypeScript#49160 . Typescript's new moduleResolution type doesn't look at the top-level types field in your package.json (it now uses the logic specified in https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing)

@shadowspawn
Copy link
Collaborator

What version of Commander are you using?

There was support added in Commander v9.2.0 for (at the time) "NodeNext" type resolution.

Reference: #1703 #1704

@kwasimensah
Copy link
Author

yup, nevermind. I'm using 9.1.0. I'll update. Thanks!

@shadowspawn
Copy link
Collaborator

An answer was provided, and no further activity in a month. Closing this as resolved.

Feel free to open a new issue if it comes up again, with new information and renewed interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants