Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to fail the job if the patterns are invalid #626

Merged
merged 11 commits into from
Jan 18, 2023
Merged

feat: update to fail the job if the patterns are invalid #626

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
341b63c
feat: update to fail the job if the patterns are invalid
jackton1 Jan 18, 2023
e1177ca
Update main.test.ts
jackton1 Jan 18, 2023
f21d97d
Update src/__tests__/main.test.ts
jackton1 Jan 18, 2023
a946b1b
Updated to raise error
jackton1 Jan 18, 2023
4df71b5
Update main.test.ts
jackton1 Jan 18, 2023
9458b9c
Merge 4df71b5d978b0bb56007ce898b812c69b6b94b04 into 70ce922e4d1a761f4…
jackton1 Jan 18, 2023
1f22b40
Added missing changes and modified dist assets.
actions-user Jan 18, 2023
89a76de
Updated the action
jackton1 Jan 18, 2023
b5809cc
Merge 89a76de11105b921a6fd33c36912f59d044cd94c into 70ce922e4d1a761f4…
jackton1 Jan 18, 2023
f94b196
Added missing changes and modified dist assets.
actions-user Jan 18, 2023
f36ffdd
Updated the test
jackton1 Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/__tests__/main.test.ts
View file
Open in desktop
Expand Up @@ -385,12 +385,7 @@ test('warnings are logged when files are not found', async () => {
INPUT_FILES: 'src/__tests__/not-found.txt'
})

// @ts-ignore
core.warning = jest.fn()

await run()

expect(core.warning).toHaveBeenCalledWith(
'No paths found using the specified patterns'
)
const expectedError = new Error('No paths found using the specified patterns')

jackton1 marked this conversation as resolved.
Show resolved Hide resolved
jackton1 marked this conversation as resolved.
Show resolved Hide resolved
await expect(run()).rejects.toThrow(expectedError)
})
2 changes: 1 addition & 1 deletion src/main.ts
View file
Open in desktop
Expand Up @@ -277,7 +277,7 @@ export async function run(): Promise<void> {
core.saveState('paths-output-file', pathsOutputFile)
core.info(`Successfully created paths-output-file: ${pathsOutputFile}`)
} else if (hasCustomPatterns) {
core.warning('No paths found using the specified patterns')
core.setFailed('No paths found using the specified patterns')
}

core.setOutput('paths', pathsOutput)
Expand Down