Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude match directory #346

Merged
merged 3 commits into from Aug 23, 2022
Merged

Conversation

jackton1
Copy link
Member

@jackton1 jackton1 commented Aug 23, 2022

Top-level directories would no longer be included in the list of matched paths

BEFORE

src/*.js

would match

src
src/test.js

This resulted in a bug where using all excluded patterns

!src/test.js

would only exclude the exact match leaving the top level directory which introduced a bug for dependent actions

Solution

src/*.js

would now match

src/test.js

and not include the top-level directory.

@jackton1 jackton1 changed the title feat: update to exclude match directory feat: exclude match directory with sub-directory glob pattern Aug 23, 2022
@jackton1 jackton1 changed the title feat: exclude match directory with sub-directory glob pattern feat: exclude match directory with sub-directory glob patterns Aug 23, 2022
@jackton1 jackton1 merged commit 19a8227 into main Aug 23, 2022
@jackton1 jackton1 deleted the feat/update-to-exclude-match-directory branch August 23, 2022 04:15
@jackton1 jackton1 changed the title feat: exclude match directory with sub-directory glob patterns feat: exclude match directory Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants