Merge pull request #626 from tj-actions/feat/update-to-fail-the-job-i…

…f-the-patterns-are-invalid

feat: update to fail the job if the patterns are invalid

.github/workflows/test.yml

@@ -220,10 +220,17 @@ jobs:
       - name: Run glob with invalid patterns
         uses: ./
         id: glob-invalid
+        continue-on-error: true
         with:
           files: |
             - *.md
 
+      - name: Exit with 1 if no error is raised
+        if: steps.glob-invalid.outcome != 'failure'
+        run: |
+          echo "Expected: (failure) got ${{ steps.changed-files.outcome }}"
+          exit 1
+
       - name: Show output
         if: steps.glob-invalid.outputs.paths != '' || steps.glob-invalid.outputs.paths-output-file != ''
         run: |

src/__tests__/main.test.ts

@@ -379,18 +379,12 @@ test('matched file patterns with braces are expanded', async () => {
   expect(core.setOutput).toHaveBeenNthCalledWith(2, 'paths', EXPECTED_FILENAMES)
 })
 
-test('warnings are logged when files are not found', async () => {
+test('error raised when files are not found', async () => {
   mockedEnv({
     ...defaultEnv,
     INPUT_FILES: 'src/__tests__/not-found.txt'
   })
 
-  // @ts-ignore
-  core.warning = jest.fn()
-
-  await run()
-
-  expect(core.warning).toHaveBeenCalledWith(
-    'No paths found using the specified patterns'
-  )
+  const expectedError = new Error('No paths found using the specified patterns')
+  await expect(run()).rejects.toThrow(expectedError)
 })

src/main.ts

@@ -277,7 +277,7 @@ export async function run(): Promise<void> {
     core.saveState('paths-output-file', pathsOutputFile)
     core.info(`Successfully created paths-output-file: ${pathsOutputFile}`)
   } else if (hasCustomPatterns) {
-    core.warning('No paths found using the specified patterns')
+    throw new Error('No paths found using the specified patterns')
   }
 
   core.setOutput('paths', pathsOutput)
@@ -288,6 +288,5 @@ if (!process.env.TESTING) {
   // eslint-disable-next-line github/no-then
   run().catch(e => {
     core.setFailed(e.message || e)
-    throw e
   })
 }

src/utils.ts

@@ -49,7 +49,7 @@ export async function deletedGitFiles({
   })
 
   if (topDirStderr || topDirExitCode !== 0) {
-    core.setFailed(topDirStderr || 'An unexpected error occurred')
+    throw new Error(topDirStderr || 'An unexpected error occurred')
   }
 
   const topLevelDir = topDirStdout.trim()
@@ -63,7 +63,7 @@ export async function deletedGitFiles({
   )
 
   if (stderr || exitCode !== 0) {
-    core.setFailed(stderr || 'An unexpected error occurred')
+    throw new Error(stderr || 'An unexpected error occurred')
   }
 
   const deletedFiles = stdout
@@ -150,7 +150,9 @@ async function* lineOfFileGenerator({
   excludedFiles: boolean
 }): AsyncIterableIterator<string> {
   const fileStream = createReadStream(filePath)
-  fileStream.on('error', (error: string | Error) => core.setFailed(error))
+  fileStream.on('error', error => {
+    throw error
+  })
   const rl = createInterface({
     input: fileStream,
     crlfDelay: Infinity