Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: including changed files from merge commits, no merge-base found #736

Merged
merged 38 commits into from
Nov 3, 2022

Conversation

jackton1
Copy link
Member

@jackton1 jackton1 commented Nov 1, 2022

No description provided.

@jackton1 jackton1 closed this Nov 1, 2022
@jackton1 jackton1 reopened this Nov 1, 2022
@jackton1 jackton1 marked this pull request as draft November 1, 2022 19:36
@jackton1 jackton1 marked this pull request as ready for review November 2, 2022 21:39
@jackton1 jackton1 changed the title fix: including changed files from merge commits fix: including changed files from merge commits, no merge-base found Nov 3, 2022
@jackton1 jackton1 merged commit d96e4cf into main Nov 3, 2022
@jackton1 jackton1 deleted the fix/including-changed-files-from-merge-commits branch November 3, 2022 16:28
@jackton1 jackton1 linked an issue Nov 4, 2022 that may be closed by this pull request
3 tasks
diff-sha.sh Show resolved Hide resolved
diff-sha.sh Show resolved Hide resolved
diff-sha.sh Show resolved Hide resolved
@lpulley
Copy link
Contributor

lpulley commented Nov 8, 2022

@jackton1 removing max_fetch_depth is a breaking change that has been pushed to v34. This should have been v35 if it is going to break things -- it broke our CI which refers to @v34. How quickly can the v34 head be fixed to not break from v34.0.0?

@jackton1
Copy link
Member Author

@lpulley Sorry for breaking your world, honest mistake I assume this input wasn't used and at most a warning would be generated for invalid input. This should be resolved in the latest release. Going forward changes that impact inputs would be made in new major versions.

@lpulley
Copy link
Contributor

lpulley commented Nov 10, 2022

Thanks! As long as breaking changes aren't only minor/patch increments, it should be fine and we can adjust our configuration to continue working.

@lpulley
Copy link
Contributor

lpulley commented Dec 14, 2022

v34 seems to have been broken again: 49ac42e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong changed-files returned for forked PRs
3 participants