Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #536

Merged
merged 3 commits into from Jun 28, 2022
Merged

Update README.md #536

merged 3 commits into from Jun 28, 2022

Conversation

JoeOvo
Copy link
Contributor

@JoeOvo JoeOvo commented Jun 28, 2022

Make it extra clear that some of these outputs only work if the files parameter has been specified. If files has not been specified, then they don't work.

#393

Make it extra clear that some of these outputs only work if the `files` parameter has been specified. If `files` has not been specified, then they don't work.
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix, could you ensure that the test covers your changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 12 potential problems in the proposed changes. Check the Files changed tab for more details.

@jackton1
Copy link
Member

@all-contributors please add @JoeOvo for docs

@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @JoeOvo! 🎉

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.

@jackton1 jackton1 merged commit 736c959 into tj-actions:main Jun 28, 2022
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 12 potential problems in the proposed changes. Check the Files changed tab for more details.

@jackton1
Copy link
Member

Nicely done @JoeOvo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants