Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to do a three dots diff #702

Closed
erezrokah opened this issue Oct 20, 2022 · 3 comments 路 Fixed by #703
Closed

Ability to do a three dots diff #702

erezrokah opened this issue Oct 20, 2022 · 3 comments 路 Fixed by #703

Comments

@erezrokah
Copy link

Hi 馃憢 Thank you for this great action 馃殌

On pull requests events it's quite useful to do a three dots diff, otherwise if the PR branch is not up to date with the base branch, the result of the diff is unexpected (changes are calculated from the top of the base branch so the output contains files not changed by the PR).

The fix would be to pass either .. or ... for all the diff commands, for example:

sub_commit_pre="$(git diff "$base" "$sha" -- "$sub" | grep '^[-]Subproject commit' | awk '{print $3}')"

If this makes sense I can submit a PR

@github-actions
Copy link
Contributor

Thanks for reporting this issue, don't forget to star this project if you haven't already to help us reach a wider audience.

@jackton1
Copy link
Member

@erezrokah This is now available in the latest release.

@erezrokah
Copy link
Author

Thanks @jackton1 for the super quick fix 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants