Merge pull request #666 from tj-actions/chore/remove-redundant-since-…

…last-remote-input chore: remove redundant since last remote commit input
tj-actions · Oct 2, 2022 · dd7c814 · dd7c814
2 parents a86508a + 677536f
commit dd7c814
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 17 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -816,11 +816,6 @@ jobs:
           echo '${{ toJSON(steps.changed-files-custom-sha.outputs) }}'
         shell:
           bash
-      - name: Run changed-files with since_last_remote_commit set to true
-        id: changed-files-since-last-remote-commit
-        uses: ./
-        with:
-          since_last_remote_commit: 'true'
       - name: Show output
         run: |
           echo '${{ toJSON(steps.changed-files-since-last-remote-commit.outputs) }}'

diff --git a/README.md b/README.md
@@ -156,7 +156,6 @@ Support this project with a :star:
 |                  sha                   |        `string`        |  `true`  |  `${{ github.sha }}`  |                                                                                                                           Specify a different <br> commit SHA <br> used for <br> comparing changes                                                                                                                            |
 |               base\_sha                |        `string`        | `false`  |                       |                                                                                                                         Specify a different <br> base commit SHA <br> used for <br> comparing changes                                                                                                                         |
 |                  path                  |        `string`        | `false`  |         `'.'`         |                                                                                                                              Relative path under <br> `GITHUB_WORKSPACE` <br> to the repository                                                                                                                               |
-|      since\_last\_remote\_commit       |       `boolean`        | `false`  |        `false`        |       Use the last commit on the remote <br> branch as the `base_sha` <br> (Defaults to the last commit <br> on the target branch for Pull requests <br> or the previous commit <br> on the current branch <br> for push events). <br /> **NOTE:** This requires <br /> `fetch-depth: 0` <br /> with `actions/checkout@v3`        |
 |               quotepath                |       `boolean`        | `false`  |        `true`         |                                                                                                                                Output filenames completely verbatim by setting this to `false`                                                                                                                                |
 |             diff\_relative             |       `boolean`        | `false`  |                       |                                                                                                                       Exclude changes outside the current directory and show pathnames relative to it. **NOTE:** This requires you to specify the top level directory via the `path` input.                                                                                                                     |
 |               dir\_names               |       `boolean`        | `false`  |        `false`        |                                                                                        Output unique changed directories instead of filenames. <br> **NOTE:** This returns `.` for <br> changed files located in the root of the project.                                                                                         |
@@ -287,12 +286,6 @@ Support this project with a :star:
             echo "$file was added"
           done
 
-      - name: Run changed-files using the last commit on the remote branch
-        id: changed-files-since-last-remote-commit
-        uses: tj-actions/changed-files@v31
-        with:
-          since_last_remote_commit: "true"
-
       - name: Run changed-files with quotepath disabled
         id: changed-files-quotepath
         uses: tj-actions/changed-files@v31

diff --git a/action.yml b/action.yml
@@ -50,10 +50,6 @@ inputs:
   base_sha:
     description: "Specify a base commit SHA on used for comparing changes"
     required: false
-  since_last_remote_commit:
-    description: "Use the last commit on the remote branch as the base_sha for push event."
-    required: false
-    default: "false"
   since:
     description: "Get changed files for commits whose timestamp is older than the given time"
     required: false
@@ -165,7 +161,6 @@ runs:
         INPUT_BASE_SHA: ${{ inputs.base_sha }}
         INPUT_SHA: ${{ inputs.sha }}
         INPUT_PATH: ${{ inputs.path }}
-        INPUT_SINCE_LAST_REMOTE_COMMIT: ${{ inputs.since_last_remote_commit }}
     - run: |
         # "Calculate the sha..."
         bash $GITHUB_ACTION_PATH/get-sha.sh