Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turborepo 추가 #2011

Merged
merged 18 commits into from Apr 11, 2022
Merged

turborepo 추가 #2011

merged 18 commits into from Apr 11, 2022

Conversation

drakang4
Copy link
Contributor

@drakang4 drakang4 commented Mar 21, 2022

PR 설명

#1913

변경 내역

  • turborepo를 추가합니다.
  • build 관련 스크립트를 lerna 대신 turbo를 사용하도록 변경합니다.
  • 재빌드시 캐시를 사용할 수 있도록 빌드 캐시를 삭제하던 prebuild를 제거합니다.
  • build:ci 를 제거합니다. 약 4개월전 next.js 빌드시에 발생하던 이상현상을 우회하기 위해 추가된 스크립트인데 이제는 해결되었다고 예상합니다. https://titicaca.slack.com/archives/CEEPB4TDY/p1636436871218400
  • docs의 storybook 실행 스크립트 이름을 변경합니다. dev -> storybook, build -> build-storybook. 이 이름은 스토리북 ecosystem에서 가장 많이 사용되는 컨벤션입니다. 또한 turbo run build가 스토리북을 빌드하지 않도록 합니다.
    • chromatic ci 설정에서 buildScriptName의 기본값이 build-storybook이므로 이 설정을 제거합니다.
  • clean 스크립트를 lerna exec rm -rf 대신 rimraf를 사용하도록 변경합니다. glob을 사용할 수 있어서 각 패키지들 대신에 root에서 한번만 커맨드를 실행해서 같은 작업을 수행 가능합니다.

@drakang4 drakang4 requested a review from a team as a code owner March 21, 2022 08:08
@drakang4 drakang4 self-assigned this Mar 21, 2022
@drakang4 drakang4 added this to the v8 milestone Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #2011 (41379cd) into main (d7a4a4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2011   +/-   ##
=======================================
  Coverage   31.77%   31.77%           
=======================================
  Files         545      545           
  Lines       10310    10310           
  Branches     3068     3068           
=======================================
  Hits         3276     3276           
  Misses       6765     6765           
  Partials      269      269           
Impacted Files Coverage Δ
...kages/action-sheet/src/components/action-sheet.tsx 89.83% <ø> (ø)
packages/popup/src/index.tsx 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a4a4f...41379cd. Read the comment docs.

Copy link
Contributor

@inbeom inbeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

패키지 생성 시 필요한 package.json 양이 늘어났으니 스캐폴딩의 요구도 더 커졌네용. 그런데 CI에서 수행하는 build 스크립트 이후 산출물은 캐싱이 되고 있는 걸까용? actions/cache는 node_modules만 보고 있을 것 같은데, 빌드 아티팩트를 캐싱해두면 partial build를 잘 활용할 수 있을거라고 생각했어요!

Copy link
Contributor

@polysiya polysiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build:ci 제거 건이 있으므로 조심스럽게 적용해봐야겠군요

packages/action-sheet/src/components/action-sheet.tsx Outdated Show resolved Hide resolved
@drakang4
Copy link
Contributor Author

drakang4 commented Mar 23, 2022

패키지 생성 시 필요한 package.json 양이 늘어났으니 스캐폴딩의 요구도 더 커졌네용. 그런데 CI에서 수행하는 build 스크립트 이후 산출물은 캐싱이 되고 있는 걸까용? actions/cache는 node_modules만 보고 있을 것 같은데, 빌드 아티팩트를 캐싱해두면 partial build를 잘 활용할 수 있을거라고 생각했어요!

https://github.com/titicacadev/triple-frontend/runs/5655500375?check_suite_focus=true#step:6:632
image

빌드 캐시 적용되었습니다!

@inbeom
Copy link
Contributor

inbeom commented Mar 23, 2022

와... 저세상의 빌드시간이네요 ㅋㅋㅋ

@drakang4 drakang4 force-pushed the feature/turbo-2 branch 2 times, most recently from b898615 to 4fe74e5 Compare March 23, 2022 09:13
polysiya
polysiya previously approved these changes Mar 23, 2022
kooinsung
kooinsung previously approved these changes Mar 24, 2022
Copy link
Contributor

@kooinsung kooinsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drakang4
Copy link
Contributor Author

release-canary

@github-actions
Copy link

v7.1.1-pr-2011.39 has been published!

@drakang4
Copy link
Contributor Author

이거 이제 머지해보려고 합니다. 다시 리뷰 한번 부탁드립니다.
build:ci 제거는 더 검증해봐야 할 것 같아서 다시 되돌리고 다른 pr에서 다뤄보려고 합니다.

@drakang4 drakang4 requested a review from a team April 11, 2022 03:23
polysiya
polysiya previously approved these changes Apr 11, 2022
Copy link
Contributor

@inbeom inbeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오.. 기대됩니다

@drakang4 drakang4 linked an issue Apr 11, 2022 that may be closed by this pull request
3 tasks
@drakang4 drakang4 merged commit af3a5ae into main Apr 11, 2022
@drakang4 drakang4 deleted the feature/turbo-2 branch April 11, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

turborepo 사용
5 participants